Refactor mcp tools to use FastMCP composition#25
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the MCP tools architecture from direct tool registration to a composition-based approach using FastMCP's import_server() method. The goal is to create standalone servers for each domain (accounts, transactions, budgets) and compose them into the main server.
Key Changes:
- Replaced
register_tools()functions withcreate_*_server()functions that return FastMCP instances - Introduced
compose_all_servers()async function to import domain servers into the main server - Modified server initialization to call composition logic during module initialization
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lampyrid/tools/transactions.py | Refactored from register_tools() to create_transactions_server() that returns a standalone FastMCP server |
| src/lampyrid/tools/budgets.py | Refactored from register_tools() to create_budgets_server() that returns a standalone FastMCP server |
| src/lampyrid/tools/accounts.py | Refactored from register_tools() to create_accounts_server() that returns a standalone FastMCP server |
| src/lampyrid/tools/init.py | Changed from register_all_tools() to async compose_all_servers() using import_server() |
| src/lampyrid/server.py | Added _initialize_server() function and uses asyncio.run() to compose servers during module initialization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #15